Comments on: Java Email Address class

By: admin

admin — Fri, 04 Feb 2011 01:03:33 +0000

Hi everyone,

I created this project to make this an Open Source effort, so everyone can participate, contribute patches, and make this even better:

http://code.google.com/p/emailaddress/

Please contribute!

Best,

Les

By: Casey

Casey — Fri, 26 Mar 2010 05:05:55 +0000

Hi again -

for those having issues with speed and recursion, or needing the ability to extract parts of address or headers, i rewrote a lot of the code to help with that:

http://boxbe.com/freebox.html

We have used it for several years to relatively-efficiently parse/process several billion in-the-wild addresses. There _are_ still a few lingering hangups on highly unusual addresses (i.e. spam garbage) that bring down a server from time to time (working on that, don’t hold your breath), but it’s otherwise pretty solid. It’s about 3-4 times slower than the (much, much simpler) JavaMail parser.

I agree with Les that an open-source project is in order (don’t have the time to set it up now, sorry). I was given wise-sounding advice that use of a lexer is in order for serious efficiency (perhaps JFlex? JavaCC?), since no solution based on regex is ever going to be fast and accurate both, given the formidable (some say “insanely unparsable”) flexibility of 2822.

Hope that helps.

By: Les

Les — Fri, 26 Feb 2010 15:49:02 +0000

@Oliver

That may be the case due to the Java regex parser implementation.

I think it’s about time to create an open source project for this and focus on speed. We’ll probably need to turn it in to a combo of scanning + regex, but the community can definitely benefit from this.

Regards,

Les

By: Oliver

Oliver — Fri, 26 Feb 2010 13:03:30 +0000

Unfortunately the running time for long email addresses prohibits the use of your surely great code in most projects…

By: johnstok

johnstok — Thu, 25 Feb 2010 16:18:34 +0000

Les,

Calling isValidText() for the following email address seems to cause an infinite loop:

ea8322fd-eac3-4f24-a0f1-bd05e10fda53@abc.def

Otherwise very useful

By: Beppe Sabatini

Beppe Sabatini — Sun, 21 Feb 2010 01:31:04 +0000

Many thanks! Here’s a paragraph I added to my copy:
// Legal top-level domains: // http://data.iana.org/TLD/tlds-alpha-by-domain.txt


	private Set TLDs;
	public EmailValidator() {

		this.TLDs = new HashSet();
		try {

			InputStream tldIs = Resources.getResourceAsStream("properties/tlds-alpha-by-domain.txt");

			DataInputStream tldDis = new DataInputStream(tldIs);

			BufferedReader tldBr = new BufferedReader(new InputStreamReader(tldDis));

			String strLine;

			// Read file line by line

			while ((strLine = tldBr.readLine()) != null) {

				if(StringUtils.isBlank(strLine)){

					continue;

				}

				if("#".equals(strLine.substring(0,1))){

					continue;

				}

				TLDs.add(strLine);

			}

			// Close the input stream

			tldDis.close();

		} catch (Exception e) {// Catch exception if any

			System.err.println("Error: " + e.getMessage());

		}

	}
	public boolean isValidTopLevelDomain(String email){

		if(StringUtils.isBlank(email)){

			return(false);

		}

		String[] domains = email.split("\\.");

		if(domains.length < 2){

			return(false);

		}

		String topLevelDomain = domains[domains.length - 1].toUpperCase();

		if(TLDs.contains(topLevelDomain)){

			return(true);

		}

		return(false);

	}

By: amine

amine — Thu, 12 Nov 2009 22:16:20 +0000

salut t l mond

By: Michael

Michael — Tue, 10 Nov 2009 10:15:34 +0000

OK, as I suspected the characters I wanted to appear in my previous post didn’t appear! What I meant to say was that all occurences of >

By: Michael

Michael — Tue, 10 Nov 2009 10:12:00 +0000

@Hugh #89438 (and Les):

I had the same problem as you did copying the code from the web page, it’s all run together into a single line with no line breaks! The way I got around this was to view the source of the page (Ctrl-U in Firefox) and copy the code from the source window, which preserved the line breaks correctly. However, it was then necessary to replace all occurrences of > < and & with >

By: Ken T

Ken T — Sun, 04 Oct 2009 06:15:21 +0000

The class is great. I used a previous version some time ago. Thanks for the work!

This comment isn’t really about the code though. You can delete the comment if you want. I just thought I should tell you that whoever is delivering your ads is really picking awful ads to put on your site..

Find anyone’s email
The JCrew home page.

If you are using ad revenue to pay for hosting, you might want to find a way to convince the supplier to pick more pertinent ads.

Good luck. BTW, I did my part.